[SteamOverHolland] fixes train discount bug #11169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
requested changes
Aug 23, 2024
ollybh
reviewed
Aug 25, 2024
ollybh
reviewed
Aug 29, 2024
|
I've just submitted a new commit, which seems to resolve the issue, and shouldn't break any games. |
ollybh
reviewed
Sep 19, 2024
There was a problem hiding this comment.
I think that there might still be a potential bug lurking in here: part of the test at the start of Step::BuyTrain.must_sell_shares? is whether the corporation has more cash than the face value of the cheapest train. What happens if the corporation that owns the Werkspoor private has no train and between 90% and 100% the price of the cheapest train? Will they be able to sell shares, even though this isn't needed to buy the train.
You might need to change this test to use the Depot.min_price(corporation, ability) function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11163
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Changes the emergency_issuable_bundles method to read @depot.min_price(ability: nil) instead of @depot.min_depot_price
I had to remove a fixture file that broke as a result. Also, this will break any alpha games with this private, and possibly all of them.
Screenshots
Any Assumptions / Hacks